From 1ea37b6e869dd1fde88773ea7ff074d229989e69 Mon Sep 17 00:00:00 2001 From: Quinn Date: Thu, 24 Jul 2025 16:06:56 +0200 Subject: [PATCH] fix: there is no need to let the compilation continue if it fails. it actually makes it less easy to locate errors. --- .github/workflows/ci.yaml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index acf9bcd..d717836 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -43,11 +43,7 @@ jobs: git clone https://github.com/microsoft/vcpkg.git "$VCPKG_ROOT" "$VCPKG_ROOT/bootstrap-vcpkg.sh" "$VCPKG_ROOT/vcpkg" install $DEPS_VCPKG - # compilation (using bulk compilation) - - run: make all CALL=compile -j || echo "JOB_FAILED=1" >>"$GITHUB_ENV" - # executing unit tests (using bulk flags) - - run: make all CALL=run DEBUG=test -j || echo "JOB_FAILED=1" >>"$GITHUB_ENV" - # exit if any errors occurred - - name: exit on errors - run: | - [ "$JOB_FAILED" != "1" ] + - name: compilation (using bulk compilation) + run: make all CALL=compile -j + - name: unit tests (using bulk flags) + run: make all CALL=run DEBUG=test -j