thepigeongenerator/tetris_clone
1
0
Fork 0
mirror of https://github.com/thepigeongenerator/tetris_clone.git synced 2025-12-17 05:55:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: extra loops when val is found

Browse Source 
when `val` was found, we continue looping, which is actually bad, since
the count will continue increasing, thus causing errors.
This commit is contained in:
Quinn
2025-04-19 18:26:13 +02:00
parent cf64cb078e
commit cd8e0ec68e
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/game/opts.c
View File

@@ -32,10 +32,12 @@ int load_opts(void) {
for (unsigned i = 0; i < BUF_SIZE; i++) { for (unsigned i = 0; i < BUF_SIZE; i++) {
// handling of special characters (in the order of most common to least) // handling of special characters (in the order of most common to least)
if (buf[i] == ' ') continue; // spaces are ignored; neither keys or values can contain spaces if (buf[i] == ' ' || buf[i] == '\t') { // whitespace is ignored; neither keys or values can contain spaces
if (buf[i] == '\t') continue; // ^ same with tabs if (!val) continue;
if (buf[i] == '\n') break; // don't check \0, since if \n isn't present, the string will be BUF_SIZE length else break; // if val was found; break out of the loop
if (buf[i] == '#') break; // stop the rest of the data is a comment }
if (buf[i] == '\n') break; // don't check \0, since if \n isn't present, the string will be BUF_SIZE length
if (buf[i] == '#') break; // stop the rest of the data is a comment
// increment the key/value length if set // increment the key/value length if set
if (val) val_len++; // first check if value is set, as it is set last if (val) val_len++; // first check if value is set, as it is set last
@@ -44,7 +46,7 @@ int load_opts(void) {
// get the values // get the values
if (!key) key = &buf[i]; // store the key's pointer at this point if (!key) key = &buf[i]; // store the key's pointer at this point
else if (!feq) feq = (buf[i] == '='); // otherwise store whether we've found the equal sign else if (!feq) feq = (buf[i] == '='); // otherwise store whether we've found the equal sign
else if (!val) val = &buf[i]; // otherwise store the start of the value pointer PERF: we can optimise this further by stopping the loop as soon as we reach another space at this point else if (!val) val = &buf[i]; // otherwise store the start of the value pointer
else { } else { }
} }